owenryan/carbonopoly
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix GameSystemController and TestGameSystem #87

Merged
40435022 merged 2 commits from cadhan/Fix_gameBoardController into dev 2025-11-15 23:01:13 +00:00
Conversation 5 Commits 2 Files changed 2 +55 -48
40435022 commented 2025-11-15 22:56:06 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

Ensure that GameSystemController uses getBoard() from GameSystem
Fix TestGameSystem trying to modify currentPlayerIndex as an int when it is now an IntegerProperty Glory to JavaFX

Ensure that GameSystemController uses getBoard() from GameSystem Fix TestGameSystem trying to modify currentPlayerIndex as an int when it is now an IntegerProperty Glory to JavaFX
40435022 commented 2025-11-15 22:56:06 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

requested review from @40441512, @40457809, @40446360, @40439721, @40444856, and @40441188

requested review from @40441512, @40457809, @40446360, @40439721, @40444856, and @40441188
40435022 commented 2025-11-15 22:56:06 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

assigned to @40435022

assigned to @40435022
40439721 (Migrated from gitlab.eeecs.qub.ac.uk) approved these changes 2025-11-15 22:56:06 +00:00
40435022 (Migrated from gitlab.eeecs.qub.ac.uk) scheduled this pull request to auto merge when all checks succeed 2025-11-15 22:56:24 +00:00
40439721 commented 2025-11-15 23:01:12 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

approved this merge request

approved this merge request
40435022 commented 2025-11-15 23:01:14 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

mentioned in commit 39d58cc9a3

mentioned in commit 39d58cc9a315bf5cb633742173e56537278e99a7
40435022 (Migrated from gitlab.eeecs.qub.ac.uk) merged commit 39d58cc9a3 into dev 2025-11-15 23:01:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
40439721
Labels
Clear labels   
bug

   
confirmed

   
critical

   
discussion

   
documentation

   
enhancement

   
game design

   
needs cadhan to fix tests

   
suggestion

   
support

   
tests

   
UI

   
under the rug
No labels
bug
confirmed
critical
discussion
documentation
enhancement
game design
needs cadhan to fix tests
suggestion
support
tests
UI
under the rug
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
owenryan/carbonopoly!87
No description provided.