GameSystem & Board Classes #75

Merged

40457809 merged 6 commits from cadhan-dev into dev 2025-11-14 15:07:28 +00:00

Conversation 24 Commits 6 Files changed 4 +357 -1

40457809 commented 2025-11-13 22:32:43 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

No description provided.

40457809 commented 2025-11-13 22:32:43 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

requested review from @40457809

requested review from @40457809

40457809 commented 2025-11-13 22:32:43 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

assigned to @40435022

assigned to @40435022

40441512 (Migrated from gitlab.eeecs.qub.ac.uk) approved these changes 2025-11-13 22:32:43 +00:00

40435022 (Migrated from gitlab.eeecs.qub.ac.uk) approved these changes 2025-11-13 22:32:43 +00:00

40457809 commented 2025-11-13 22:39:28 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

Shouldn't this return a boolean or enum?

Shouldn't this return a boolean or enum?

40457809 commented 2025-11-13 22:39:28 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

If this is public, do we need getSize()?

If this is public, do we need getSize()?

40457809 commented 2025-11-13 22:39:28 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

I know this is temporary, but going forward should the board squares be created directly by the Board class or by a factory?

I know this is temporary, but going forward should the board squares be created directly by the Board class or by a factory?

40457809 commented 2025-11-13 22:39:29 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

requested changes

requested changes

40435022 commented 2025-11-14 14:28:19 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/CSC2058-2526/CSC2058-2526-G46/-/merge_requests/15/diffs?diff_id=16272&start_sha=af77e9eef1f90ae1c4f8ec6f8149b154d954adc5#a98aa25e4a5a45e15cc46eafd2dba5b83a6597d3_65_70)

40435022 commented 2025-11-14 14:28:20 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

added 1 commit

• c8b2e799 - Add GameState enum, add exceptions for non-implemented functions

Compare with previous version

added 1 commit <ul><li>c8b2e799 - Add GameState enum, add exceptions for non-implemented functions</li></ul> [Compare with previous version](/CSC2058-2526/CSC2058-2526-G46/-/merge_requests/15/diffs?diff_id=16272&start_sha=af77e9eef1f90ae1c4f8ec6f8149b154d954adc5)

40435022 commented 2025-11-14 14:28:54 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

Added GameState enum for this to return.

Added GameState enum for this to return.

40435022 commented 2025-11-14 14:30:00 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

added 1 commit

• 2c12774e - Remove getSize() from Board

Compare with previous version

added 1 commit <ul><li>2c12774e - Remove getSize() from Board</li></ul> [Compare with previous version](/CSC2058-2526/CSC2058-2526-G46/-/merge_requests/15/diffs?diff_id=16274&start_sha=c8b2e799d11735dd298eb685a73387f109648574)

40435022 commented 2025-11-14 14:30:12 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

We do not

We do not

40435022 commented 2025-11-14 14:54:31 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/CSC2058-2526/CSC2058-2526-G46/-/merge_requests/15/diffs?diff_id=16276&start_sha=2c12774edfc4e760a1d1ccc434b1d31e488914c0#a98aa25e4a5a45e15cc46eafd2dba5b83a6597d3_29_27)

40435022 commented 2025-11-14 14:54:32 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

added 1 commit

• 8a8e82a9 - Add BoardFactory and make it used to initialise Board in GameSystem

Compare with previous version

added 1 commit <ul><li>8a8e82a9 - Add BoardFactory and make it used to initialise Board in GameSystem</li></ul> [Compare with previous version](/CSC2058-2526/CSC2058-2526-G46/-/merge_requests/15/diffs?diff_id=16276&start_sha=2c12774edfc4e760a1d1ccc434b1d31e488914c0)

40457809 commented 2025-11-14 14:59:16 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

resolved all threads

resolved all threads

40435022 commented 2025-11-14 14:59:29 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

Factory added

Factory added

40457809 commented 2025-11-14 14:59:38 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

removed review request for @40457809

removed review request for @40457809

40457809 commented 2025-11-14 14:59:52 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

resolved all threads

resolved all threads

40457809 commented 2025-11-14 15:00:12 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

requested review from @40457809

requested review from @40457809

40457809 commented 2025-11-14 15:02:18 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

removed review request for @40457809

removed review request for @40457809

40441512 commented 2025-11-14 15:02:38 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

approved this merge request

approved this merge request

40435022 commented 2025-11-14 15:07:08 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

approved this merge request

approved this merge request

40435022 commented 2025-11-14 15:07:28 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)

Copy link

mentioned in commit 032b2d1c54

mentioned in commit 032b2d1c5483b1e7ee005d5232766fc196123a64

40435022 (Migrated from gitlab.eeecs.qub.ac.uk) merged commit 032b2d1c54 into dev 2025-11-14 15:07:28 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

40441512

40435022

Labels

Clear labels   

bug

  

confirmed

  

critical

  

discussion

  

documentation

  

enhancement

  

game design

  

needs cadhan to fix tests

  

suggestion

  

support

  

tests

  

UI

  

under the rug

No labels

bug

confirmed

critical

discussion

documentation

enhancement

game design

needs cadhan to fix tests

suggestion

support

tests

UI

under the rug

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

owenryan/carbonopoly!75

No description provided.