owenryan/carbonopoly
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add initial implementation of chance cards #68

Merged
40457809 merged 5 commits from owen/chanceCards into dev 2025-11-13 16:18:53 +00:00
Conversation 10 Commits 5 Files changed 5 +207
40457809 commented 2025-11-11 00:04:48 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

Contains only two sample chance cards (one good one bad).

Needed for the chance square to be implemented (#32)

Open to comments and suggestions.

Closes #35

Contains only two sample chance cards (one good one bad). Needed for the chance square to be implemented (#32) Open to comments and suggestions. Closes #35
40457809 commented 2025-11-11 00:04:49 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

requested review from @40441512

requested review from @40441512
40457809 commented 2025-11-11 00:04:49 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

assigned to @40457809

assigned to @40457809
40457809 commented 2025-11-11 01:09:33 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

added 1 commit

  • e8c750e5 - Add isGood property to ChanceCard, and add unit tests

Compare with previous version

added 1 commit <ul><li>e8c750e5 - Add isGood property to ChanceCard, and add unit tests</li></ul> [Compare with previous version](/CSC2058-2526/CSC2058-2526-G46/-/merge_requests/8/diffs?diff_id=16101&start_sha=8edaa45e0d0db949393e8d0225df9f177c47b996)
40457809 commented 2025-11-11 01:12:41 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>6da51418 - Fix skipping tests</li></ul> [Compare with previous version](/CSC2058-2526/CSC2058-2526-G46/-/merge_requests/8/diffs?diff_id=16103&start_sha=e8c750e50504b7ddd786d2f26f1483bbf4abc3e3)
40439721 commented 2025-11-11 01:23:57 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

Some good cards could be added to "BAD_CARDS" list for example grant from government as this would mimic how government spends more if climate is bad.
Could also add multiple tiers of bad cards with more deadly chance cards making up majority of higher tier, this is probably overcomplicated unless chance card frequency increases.

Some good cards could be added to "BAD_CARDS" list for example grant from government as this would mimic how government spends more if climate is bad. Could also add multiple tiers of bad cards with more deadly chance cards making up majority of higher tier, this is probably overcomplicated unless chance card frequency increases.
40457809 commented 2025-11-11 09:57:11 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

changed the description

changed the description
40457809 commented 2025-11-13 14:36:12 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

marked this merge request as ready

marked this merge request as **ready**
40457809 commented 2025-11-13 15:29:19 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

added 1 commit

  • 6658eb0f - Move chance card classes to their own files

Compare with previous version

added 1 commit <ul><li>6658eb0f - Move chance card classes to their own files</li></ul> [Compare with previous version](/CSC2058-2526/CSC2058-2526-G46/-/merge_requests/8/diffs?diff_id=16240&start_sha=6da514182e0e87760e0042ac95f21bc6640d1cc0)
40457809 commented 2025-11-13 15:36:43 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>6367c2f5 - Fix chance card definitions</li></ul> [Compare with previous version](/CSC2058-2526/CSC2058-2526-G46/-/merge_requests/8/diffs?diff_id=16243&start_sha=6658eb0f990e518bdf539d89a91cc2b7e383dba2)
40457809 commented 2025-11-13 16:18:53 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

mentioned in commit d877b15353

mentioned in commit d877b15353d5c39be92b7b3c868ea6e5628c3629
40457809 (Migrated from gitlab.eeecs.qub.ac.uk) merged commit d877b15353 into dev 2025-11-13 16:18:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
confirmed

   
critical

   
discussion

   
documentation

   
enhancement

   
game design

   
needs cadhan to fix tests

   
suggestion

   
support

   
tests

   
UI

   
under the rug
No labels
bug
confirmed
critical
discussion
documentation
enhancement
game design
needs cadhan to fix tests
suggestion
support
tests
UI
under the rug
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
owenryan/carbonopoly!68
No description provided.