Investment fix #245

Merged

40441512 merged 5 commits from investmentFix into dev

2026-03-17 13:12:47 +00:00

40441512 commented

2026-03-16 23:58:22 +00:00

(Migrated from gitlab.eeecs.qub.ac.uk)

Investments now add to carbon meter and when they payout they have their effect removed
Effect amount depends on percentage invested
If a player is bankrupt their investments are deleted

Investments now add to carbon meter and when they payout they have their effect removed Effect amount depends on percentage invested If a player is bankrupt their investments are deleted

40457809 (Migrated from gitlab.eeecs.qub.ac.uk) approved these changes

2026-03-16 23:58:22 +00:00

40441512 (Migrated from gitlab.eeecs.qub.ac.uk) scheduled this pull request to auto merge when all checks succeed

2026-03-16 23:58:27 +00:00

40441512 commented

2026-03-17 00:04:56 +00:00

(Migrated from gitlab.eeecs.qub.ac.uk)

aborted the automatic merge because the source branch was updated. Learn more.

aborted the automatic merge because the source branch was updated. [Learn more](https://gitlab.eeecs.qub.ac.uk/help/ci/pipelines/merge_trains.md#merge-request-dropped-from-the-merge-train).

40441512 commented

2026-03-17 00:04:56 +00:00

(Migrated from gitlab.eeecs.qub.ac.uk)

added 1 commit

fddf4623 - more test fixed

Compare with previous version

added 1 commit <ul><li>fddf4623 - more test fixed</li></ul> [Compare with previous version](/CSC2058-2526/CSC2058-2526-G46/-/merge_requests/185/diffs?diff_id=20446&start_sha=90e3728f38b1a5d0b3a81c022ba7666b8d6d3c89)

40457809 commented

2026-03-17 01:19:04 +00:00

(Migrated from gitlab.eeecs.qub.ac.uk)

You might want to add a bounds check to this constructor to ensure ecoEffectMultiplier is in a specific range (0.0-1.0?)

40457809 commented

2026-03-17 01:19:04 +00:00

(Migrated from gitlab.eeecs.qub.ac.uk)

Add this if you think it's necessary, otherwise just send it

40457809 commented

2026-03-17 01:19:04 +00:00

(Migrated from gitlab.eeecs.qub.ac.uk)

approved this merge request