owenryan/carbonopoly
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

WIP: Draft: Owen/button visibility overhaul #171

Closed
40457809 wants to merge 4 commits from owen/buttonVisibilityOverhaul into dev
pull from: owen/buttonVisibilityOverhaul
merge into: owenryan:dev
Conversation 10 Commits 4 Files changed 7 +115 -174
40457809 commented 2026-03-01 01:33:30 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

In an attempt to unravel UI From core logic so saving/loading can work, button hidden/visible logic has been moved out of GameSystem and into gameBoardcontroller.

  • Create TurnState enum to declaratively represent which buttons should be visible at any time
  • Replace GameSystem's gameButtons list with a TurnState property.
  • Update GameSystem methods to replace button visibility setters with a single change to TurnState
  • Replace gameBoardController's gameButton visibility listeners with a single TurnState listener.
In an attempt to unravel UI From core logic so saving/loading can work, button hidden/visible logic has been moved out of `GameSystem` and into `gameBoardcontroller`. - Create `TurnState` enum to declaratively represent which buttons should be visible at any time - Replace `GameSystem`'s `gameButtons` list with a `TurnState` property. - Update GameSystem methods to replace button visibility setters with a single change to `TurnState` - Replace `gameBoardController`'s `gameButton` visibility listeners with a single TurnState listener.
40457809 commented 2026-03-01 01:33:30 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

requested review from @40441512, @40441188, @40446360, @40444856, @40435022, and @40439721

requested review from @40441512, @40441188, @40446360, @40444856, @40435022, and @40439721
40457809 commented 2026-03-01 01:33:30 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

assigned to @40457809

assigned to @40457809
40435022 (Migrated from gitlab.eeecs.qub.ac.uk) approved these changes 2026-03-01 01:33:30 +00:00
40446360 (Migrated from gitlab.eeecs.qub.ac.uk) approved these changes 2026-03-01 01:33:30 +00:00
40457809 commented 2026-03-01 01:34:26 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>b087e073 - Remove unused enum</li></ul> [Compare with previous version](/CSC2058-2526/CSC2058-2526-G46/-/merge_requests/111/diffs?diff_id=18995&start_sha=1a29bb236abaf5b3ee56ca59e2142a510bc2f37d)
40457809 commented 2026-03-01 01:37:25 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

marked this merge request as draft

marked this merge request as **draft**
40457809 commented 2026-03-01 01:40:11 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

removed review request for @40446360, @40441188, @40441512, @40435022, and @40444856

removed review request for @40446360, @40441188, @40441512, @40435022, and @40444856
40457809 commented 2026-03-01 01:42:29 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

added 1 commit

  • 7542cce1 - Fix incorrect number in updateButtonContainerWidth calls

Compare with previous version

added 1 commit <ul><li>7542cce1 - Fix incorrect number in updateButtonContainerWidth calls</li></ul> [Compare with previous version](/CSC2058-2526/CSC2058-2526-G46/-/merge_requests/111/diffs?diff_id=18997&start_sha=b087e073f762c099575b892108231ae8db917dc3)
40435022 commented 2026-03-01 03:20:32 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

approved this merge request

approved this merge request
40446360 commented 2026-03-03 04:07:18 +00:00 (Migrated from gitlab.eeecs.qub.ac.uk)
Copy link

approved this merge request

approved this merge request
40457809 (Migrated from gitlab.eeecs.qub.ac.uk) closed this pull request 2026-03-03 14:54:35 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
40435022
40446360
Labels
Clear labels   
bug

   
confirmed

   
critical

   
discussion

   
documentation

   
enhancement

   
game design

   
needs cadhan to fix tests

   
suggestion

   
support

   
tests

   
UI

   
under the rug
No labels
bug
confirmed
critical
discussion
documentation
enhancement
game design
needs cadhan to fix tests
suggestion
support
tests
UI
under the rug
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
owenryan/carbonopoly!171
No description provided.