Disable roll button during turn and re-enable after popups #110

Merged

40435022 merged 1 commit from cadhan/fix_roll_dice_bug into dev

2026-01-17 23:15:39 +00:00

40435022 commented

2026-01-17 23:13:16 +00:00

(Migrated from gitlab.eeecs.qub.ac.uk)

Multiple dice rolls are prevented during an unresolved turn by disabling the roll button immediately and only reenabling it once movement and any resulting popups are fully resolved.

Roll action now goes through gameBoardController.startTurn() instead of calling GameSystem.makeMove() directly.
A turnInProgress flag controls the roll button state and acts as the guard against duplicate rolls.
The reenabling logic waits until the popup queue is idle, the popups should still resolve correctly but this probably needs to be verified further.
There is no game logic changes to movement or square effects, it's just UI.

Multiple dice rolls are prevented during an unresolved turn by disabling the roll button immediately and only reenabling it once movement and any resulting popups are fully resolved. - Roll action now goes through gameBoardController.startTurn() instead of calling GameSystem.makeMove() directly. - A turnInProgress flag controls the roll button state and acts as the guard against duplicate rolls. - The reenabling logic waits until the popup queue is idle, the popups should still resolve correctly but this probably needs to be verified further. - There is no game logic changes to movement or square effects, it's just UI.

40435022 commented

2026-01-17 23:13:16 +00:00

(Migrated from gitlab.eeecs.qub.ac.uk)

requested review from @40441512, @40446360, @40439721, @40444856, @40441188, and @40457809

40435022 commented

2026-01-17 23:13:16 +00:00

(Migrated from gitlab.eeecs.qub.ac.uk)

assigned to @40435022

40457809 (Migrated from gitlab.eeecs.qub.ac.uk) approved these changes

2026-01-17 23:13:16 +00:00

40435022 (Migrated from gitlab.eeecs.qub.ac.uk) scheduled this pull request to auto merge when all checks succeed

2026-01-17 23:13:24 +00:00